nipkownix
commented
2 years ago Do you think separating like this is fine, or is it maybe a bit too far?
Nah, this is fine, actually. I was trying to think of ways of splitting Game.h somehow, but your solution is better than anything I came up with. Thanks for that!
Also updated some of the structs with the new findings, need to make sure that things still match up/work as we expect before merging though (mostly seems to be fine from what I checked, but wouldn't be surprised if some offset got broken somewhere...)
Ah, cool. I'll do some testing later, then.
Hey, wanted to get your thoughts on this, the Game.h seemed to be filling up (and will probably get even bigger soon :p), so figured we should probably split it up.
Tried separating things here by filenames I've seen in the symbols, 90% of these are actual header names the game used, but some I only saw as .cpp/.c and figured there was probably a .h for it too.
Do you think separating like this is fine, or is it maybe a bit too far? We aren't a decompilation project or anything like that so maybe naming stuff like this is a bit useless... there are a couple files in here which pretty much just have a single struct inside too, maybe more could be added later too, but not sure.
It might be convenient though since the symbols can be split into .cpp files pretty easily, so can pretty much just use the same filename that a struct was found inside (the symbols don't actually say which header a struct belongs to though, mainly just what .cpp/.c/.obj some code was from, so have to guess it from that... should be close enough though)
Also updated some of the structs with the new findings, need to make sure that things still match up/work as we expect before merging though (mostly seems to be fine from what I checked, but wouldn't be surprised if some offset got broken somewhere...)