search

nipkownix / re4_tweaks

Fixes and tweaks for the "UHD" port of Resident Evil 4
zlib License
341 stars 32 forks source link

Created Gameplay tab in ImGui #392

Closed pas-de-2 closed 1 year ago

pas-de-2 commented 1 year ago

For https://github.com/nipkownix/re4_tweaks/pull/366#issuecomment-1364454566

pas-de-2 commented 1 year ago

UseSprintToggle and LimitMatildaBurst are technically more like controller tweaks. I suppose we could duplicate UseSprintToggle in the Keyboard and Controller tabs, and LimitMatildaBurst in the Mouse and Controller tabs?

nipkownix commented 1 year ago

Moved stuff to a new .cpp file and changed our .ini a bit. Should probably make sure everything still works correctly.. I've messed that up in the past ._.

UseSprintToggle and LimitMatildaBurst are technically more like controller tweaks. I suppose we could duplicate UseSprintToggle in the Keyboard and Controller tabs, and LimitMatildaBurst in the Mouse and Controller tabs?

Hmm, I think since the implementation for them is the same for KB/M and controllers, leaving them in the Gameplay tab should be fine?

pas-de-2 commented 1 year ago

Oh, it's a shame that moving settings between tabs resets people's existing config settings. Any reason the ini reader shouldn't just check for the whole file?

nipkownix commented 1 year ago

Any reason the ini reader shouldn't just check for the whole file?

Hmm, just to keep things organized, I guess? It isn't that big a deal IMO. But should probably add a warning in the release changelog mentioning that some settings may have reverted back to default...

pas-de-2 commented 1 year ago

What about grouping DisableQTE and AutomaticMashingQTE within the same column, like in https://github.com/nipkownix/re4_tweaks/pull/366#issuecomment-1364454566? I can't tell if you didn't like that or if you just merged over it with your existing changes, heh.

nipkownix commented 1 year ago

Oh shoot, I think I may have accidentally overwritten that when changing the order of the settings. Sorry! It does look better.

Edit: Restored the Matilda group too. Thanks for the heads up!

nipkownix commented 1 year ago

Everything looks good to me. Thanks again, @pas-de-2.