nipkownix / re4_tweaks

Fixes and tweaks for the "UHD" port of Resident Evil 4
zlib License
346 stars 32 forks source link

Misc: fix some item descriptions in the merchant and examine subscreens #438

Closed pas-de-2 closed 1 year ago

pas-de-2 commented 1 year ago

https://github.com/nipkownix/re4_tweaks/issues/434

Workaround fix for the silencer wrongly suggesting it gives the handgun a 5x crit chance when the handgun has less than max firepower:

20230110161652_1

While we're here, remove the infinite bullets description from the unupgraded Chicago Typewriter: 20230110191812_1

lextra2 commented 1 year ago

Nitpick, but why in the second image, is half the text box empty and it looks like it cuts to a new line right in the middle?

pas-de-2 commented 1 year ago

That's just how it's formatted in the MDT file.

{0x0000}  {0x1100}{0x5300}{0x0300}This machinegun is outfitted with a{0x0300}powerful .45 caliber magazine. {0x0800}{0x0100}

{0x0300} is a newline character.

It's mostly an artifact of the fact that the font was larger on the lower res GameCube/PS2:

RB4E08_2023-01-10_23-55-10 We don't have the ability to edit the MDT data in memory yet, so this fix is only redirecting what item it thinks is being looked at. In the future we could improve this to eg. restore the Handgun w/ Silencer text.

juuuulian-s commented 1 year ago

does this mean some of the unlockables are getting a rebalance/proper upgrade progression? it always bothered me how quickly you can make the matilda and the handcannon busted op since every upgrade is available from the get go.

nipkownix commented 1 year ago

Very clever workaround! Can't read the code right now, but I imagine you're not spoofing the IDs if the weapons are fully upgraded, right?

pas-de-2 commented 1 year ago

Yes, it checks for whether the weapon has its exclusive upgrade first, so eg. Wesker's pistol is unaffected.

nipkownix commented 1 year ago

Many thanks!