nipkownix / re4_tweaks

Fixes and tweaks for the "UHD" port of Resident Evil 4
zlib License
339 stars 33 forks source link

Reshade Compatibility #442

Open JonJenin opened 1 year ago

JonJenin commented 1 year ago

I would like to know is there any way to make this compatible with Reshade? It used to work fine with the version of re4_tweaks included with re4HD 1.0. Now doesn't work with v1.8.

nipkownix commented 1 year ago

ReShade should work fine as long as you either use a Vulkan version of ReShade, or disable the game's Vulkan renderer in the configuration menu.

JonJenin commented 1 year ago

Hello,

ReShade works, but for some reason, re4_tweaks always automatically reverts back to the previous version. (version that was included with vanilla RE4HD.) 

And since I'm already here, I would like to ask how QTE fix actually works?

First of all, button presses for the boulder section, minecart section, and Salazar's statue section used to be impossible to do with my thumb. I had to hold my controller like this: https://imgur.com/a/FXmrAGu  and spam the button with my index finger. 

This trick always works 99% of the time. But now with QTE fix activated, I don't need to do that anymore. It really works. Spamming the button with my thumb already suffices. I really thank you for that.

But you know the fight with El-Gigante right? Leon climbs to his back and begins slicing the plagas. The faster we press the button, the more cuts Leon will get.  For some reason, I was never able to get more than six slashes with QTE fix activated. No matter which finger I used or how fast I spammed, the best I could get was six. In order for me to get 7 cuts, I need to deactivate QTE Fix first.

I'm not complaining or anything, just wondering why it happens. Also maybe there's somebody here who can confirm they are able to get more than six cuts.

Thank you.

nipkownix commented 1 year ago

ReShade works, but for some reason, re4_tweaks always automatically reverts back to the previous version. (version that was included with vanilla RE4HD.)

Not sure why it would automatically revert, to be honest.

And since I'm already here, I would like to ask how QTE fix actually works?

The game's QTE events have a counter (sometimes counting up, sometimes counting down), and this counter is updated every frame. At 60 fps, the counters update twice as fast, which is what makes you have to mash buttons twice as fast. The QTE fix makes these counters take the delta time into account instead of using the original fixed values. So if, for example, a counter would decrease "1" every frame at 30 fps, the fix will make it decrease "0.5" instead. About El Gigante: Seems I did patch those, but maybe I missed something there. Can't remember, it has been a while. I'll take another look at it at some point.

Edit: What difficulty are you playing at, btw? This might have something to do with it. Hmm.

nipkownix commented 1 year ago

@JonJenin Can you check if this build improves something related to the El Gigante QTE? dinput8-qteTest.zip

pas-de-2 commented 1 year ago

I did some tests.

On Dolphin, professional difficulty, the max slices you can get vs El Gigante's parasite is 7, and you have to mash pretty hard to get it. With re4 tweaks, professional difficulty at 60fps, you can get 8 slices without even trying. ~With re4 tweaks, professional difficulty at 30fps, you can't get more than 6 slices no matter how hard you try.~

I unticked QTE fixes and El Gigante was (mostly?) correct at both 30fps and 60fps. Max slices of 7, and you have to mash (really) hard to get it. It looks like the game already had deltaTime fixes for this fight? @0x8ED14B

Worth going back and double checking the other mash prompt QTE fixes for bugs like this.

nipkownix commented 1 year ago

Huh, I knew the fight was probably easier with the qte fix enabled, didn't think it was that much easier though.

But I'm not sure I understand why the qte fix would make the qte harder at 30 fps. Will probably have to take a better look at this. Thanks for testing!

pas-de-2 commented 1 year ago

I looked at the QTE fix hook and it didn't make sense that it would actually make things harder at 30fps so I retested and managed to get 7 slices with the QTE fix enabled at 30fps. It's just really hard to get 7 slices in the PC port vs GameCube, especially on keyboard, regardless of fps. Not sure what's going on there...

E: tested the PAL GameCube El Gigante on professional as well to make sure it wasn't made harder intentionally in the rebalance, and it's the same difficulty as NTSC. ~Maybe just another QLOC screw up?~ Sorry for the slander QLOC 😓

nipkownix commented 1 year ago

You mentioned unticking the QTE Fixes made everything mostly correct, right? What wasn't correct? It being harder to get 7 slices on PC?

Edit: Could the amount of time you have to slice the plaga be smaller on PC?

Seems QLOC added some deltaTime stuff when setting up the timer: image

1.0 - pG->deltaTime_70 seems unnecessary though, since they're doing a1->Timer_40C = a1->Timer_40C - pG->deltaTime_70; in the loop. Meh.

I wonder if on GC the timer is also 114.0. We cooould just raise it a little bit so we can have more time to get another slice. Hmm.

pas-de-2 commented 1 year ago

Okay, after further testing, I think the function is actually correct as is, and what I thought I was seeing is just an artifact of how much harder it is to mash on a keyboard. Since I have to use a controller for Dolphin, it seemed easier. Sorry to send you on a wild goose chase. Can just get rid of the errant fix and it should be good.

nipkownix commented 1 year ago

Ah, no problem. Just removed the hooks, should be good now. Thanks for testing.