search

nipkownix / re4_tweaks

Fixes and tweaks for the "UHD" port of Resident Evil 4
zlib License
346 stars 32 forks source link

Item Pickup Screen Causes Rain to Appear Indoors #484

Open LethalPlacebo opened 1 year ago

LethalPlacebo commented 1 year ago

Validation

Describe your issue here (drag+drop ZIP to attach it)

I noticed that when picking up an item indoors while in a map where it is raining, the rain will appear indoors in the background of the item pickup screen. When you exit the screen, it's back to normal.

Edit: According to Albert, this behavior also occurs in the original GameCube version. 20230310225700_1

Mister-Curious commented 1 year ago

I have some assembly code that fixes this for one room. If anyone wants to have a look at it, let me know.

albertre4HD commented 1 year ago

This bug was also in the Gamecube. Maybe Mister-Curious code has the key for the fix

LethalPlacebo commented 1 year ago

This bug was also in the Gamecube. Maybe Mister-Curious code has the key for the fix

Updated the original post to reflect this new information, thanks Albert!

nipkownix commented 1 year ago

@Mister-Curious Would you mind posting your assembly code?

Mister-Curious commented 1 year ago

Hey sorry for the late reply. I didn't see this until now.

118 Camera Effect Fix (room number is the 18 01 part) (removes weather effects from camera shots)

83 A0 70 01 00 00 BF 6A 00 B9 78 D7

Change To:

E9 5A 65 40 00 90 90 6A 00 B9 78 D7

Find: 006C4100

Paste:

8B 0D 00 0E 2E 10 81 B9 AC 4F 00 00 18 01 00 00 74 11 B9 FF FE 00 00 83 A0 70 01 00 00 BF E9 85 9A BF FF B9 FF FE 00 00 83 A0 70 01 00 00 9F E9 74 9A BF FF

Man the formatting on GH is sketchy. I tried to use BOLD for certain parts and it made entire sections bold. I removed the bold formatting and its still there.