nipkownix / re4_tweaks

Fixes and tweaks for the "UHD" port of Resident Evil 4
zlib License
340 stars 32 forks source link

Crash when starting application and trying to patch the executable #52

Open Pablossjui opened 2 years ago

Pablossjui commented 2 years ago

When starting RE4_tweaks with www.re4hd.com's mod, and starting the game I get the message that it wants to patch it to support more than 2GB of RAM.

However the screen almost instantly freezes and I cannot select the option to do it. Tried moving mouse, hitting the Enter key or using the arrows and cannot get any response; I have to force open task manager and force close the application in order to free up my system.

https://ntcore.com/?page_id=371 This manual patcher instantly worked and was able to play using the mod right away

AMD Ryzen 5 2600 16.0 GB RAM GTX 1080 TI 16 GIG RAM No other mods BIO4 37.4 GB, 6804 files BIN32 3.92 MB, 4 files No issues before install

nipkownix commented 2 years ago

https://ntcore.com/?page_id=371 This manual patcher instantly worked and was able to play using the mod right away

After doing this manual patch, does the game freeze if you press F1 to open the configuration menu?

Pablossjui commented 2 years ago

Not at all, it plays normally and I can mess around with the settings. Only played for a couple of minutes though.

nipkownix commented 2 years ago

Interesting. I was suspecting the way I handle input in the menus was the cause of the freezing, but apparently not.

@emoose any idea?

@Pablossjui, just to confirm, it doesn't crash? If it did, we could get some log files to investigate.

laymonage commented 2 years ago

Seems that it's (possibly) caused by GeForce Experience Overlay:

https://steamcommunity.com/app/254700/discussions/0/3108018050534635927/?ctp=8#c3182358518942093219

Saidana94 commented 2 years ago

Hello all, I think this problem also occurs to those who have a 120hz or 144hz monitor, I have personally installed the mod but I can't access the game. The screen freezes instantly but I can hear the game. This means that I can't even apply the Fix display mode/black screen issue mod. I will probably have to install the 4GB patch manually and see how it goes. This is just my theory, I am not 100% sure! By the way, I don't have Geforce Experience Overlay.

I installed the 4GB Patch manually and unfortunately, it did not fix the problem, however, I found a tutorial on youtube on how to fix "the high refresh rate monitor problem". After following the tutorial I was finally able to access the game but it skipped the 4GB installation question.

The Link: https://www.youtube.com/watch?v=E8ZbxnWNFGc

Pablossjui commented 2 years ago

just to confirm, it doesn't crash? If it did, we could get some log files to investigate.

It'd be more accurate to say it freezes in place and doesn't allow to do anything but you can still see the message on the screen telling you to patch it

I do have the Geforce Experience overlay so that might do it, why though? I have no idea. Could it be because it was in exclusive-fullscreen?

nipkownix commented 2 years ago

It'd be more accurate to say it freezes in place and doesn't allow to do anything but you can still see the message on the screen telling you to patch it

I see. The game behind the message is frozen as well? Like, can you see any movement or is the image static?

nipkownix commented 2 years ago

Just to rule it out, I've changed the way input is handled in the 4gb patch window.

@Pablossjui, could you see if the issue still happens with this build?

dinput8.zip

Pablossjui commented 2 years ago

The game behind the message is frozen as well? Like, can you see any movement or is the image static?

Yes, the background is just black no movement at all.

I did some tests. Thankfully the manual patcher makes a backup of your exe file so I didn't have to redownload the whole game lol

First, I disabled the Nvidia game overlay, and can confirm it worked, it did freeze but for like 2 seconds, but then the game on the background appears and the mouse frees up too, so I can go ahead and patch it using the message.

Then, I enabled the overlay again and the issue returned. With the overlay like that, I replaced the dinput dll with the one you provided and can confirm it also worked; the game again freezed for like 2 seconds, but then it all works out like before.

Finally I AGAIN changed the dinput dll with the one from re4hd's mod and the issue reappeared.

I haven't done any more tests regarding gameplay or stability but it seems to work now with that new dll

nipkownix commented 2 years ago

I see, I see. Then it really is the way I handle input that is causing the issue. The weird part is that the configuration menu uses the exact same method, but doesn't cause problems.

Thanks for testing!

nipkownix commented 2 years ago

(posting this here since this is about the LAApatch)

@emoose I made some changes to the LAApatch. Now it doesn't use raw input (to not break whatever the Geforce Experience Overlay is doing on startup) and the OK button now forces the game to restart.

Do you think forcing the game to restart is too drastic? Unrelated to this issue, but I've seen some people pressing yes on the patch but not actually restarting the game to make the changes work.

emoose commented 2 years ago

Oh nice, wanted to add something like that too but wasn't really sure how to go about it, I think it's fine to force it since like you said many people seem to be ignoring us asking to restart.

Guess some don't bother actually reading the prompt before clicking it - maybe should add something in all-caps or bold text that pressing yes will force a restart, since some might be surprised by it.

(I wonder if maybe we should be doing the LAA stuff with windows MessageBoxes instead, before game window actually opens up, would probably look cleaner instead of game needing to start up -> exit -> start again)

nipkownix commented 2 years ago

(I wonder if maybe we should be doing the LAA stuff with windows MessageBoxes instead, before game window actually opens up, would probably look cleaner instead of game needing to start up -> exit -> start again)

True. We can keep it the way it is for now, but if some other issue happens like the nvidia one, we just switch to MessageBoxes instead.