hook::pattern sloppy code - Githubissues

nipkownix / re4_tweaks

Fixes and tweaks for the "UHD" port of Resident Evil 4

zlib License

329 stars 32 forks source link

hook::pattern sloppy code #603

Open Lioncky opened 2 months ago

Lioncky commented 2 months ago

Validation

[X] Game has been updated to the latest RE4HD release (v1.1: https://www.re4hd.com/?p=9552)
[X] Data has been validated with SFV (a guide to using QuickSFV is available at that link, use that with this 1.1 SFV: BIO4-HDProject1.1-SFV.zip)

Describe your issue here (drag+drop ZIP to attach it)

CameraTweaks:

pattern = hook::pattern("A2 ? ? ? ? EB ? DD D8 8B 0D");
AnalogRX_8 = (int8_t*)*pattern.count(1).get(0).get<uint32_t>(1);

change to: pattern = hook::pattern("EB 09 A2 ? ? ? ? EB ? DD D8 8B 0D"); AnalogRX_8 = (int8_t)pattern.count(1).get(0).get(3); AnalogRY_9 = AnalogRX_8 + 1;

Whorespawn commented 2 months ago

Can you describe in more detail what the issue is?