Closed hveravallaskreppur closed 1 year ago
Attention: 12 lines
in your changes are missing coverage. Please review.
Files | Coverage Δ | |
---|---|---|
findoutlie/__init__.py | 100.00% <100.00%> (ø) |
|
findoutlie/detectors.py | 97.43% <96.66%> (-2.57%) |
:arrow_down: |
findoutlie/tests/test_detectors.py | 94.11% <96.15%> (+6.61%) |
:arrow_up: |
findoutlie/outfind.py | 30.00% <25.00%> (-3.34%) |
:arrow_down: |
:loudspeaker: Thoughts on this report? Let us know!.
the tests all pass @kaushik-pallavi, I think it was just a codeCov service outage
about to send in another PR with GLM as metric, needed to accept PR first, @kaushik-pallavi
dvars now added in detectors.py and the findoutlie script uses dvars instead of z_score_detector. please review and merge @kaushik-pallavi (please accept the other PR first)