nipraxis-summer-2023 / diagnostics-bold_but_better

1 stars 4 forks source link

Refactor dvars #29

Closed hveravallaskreppur closed 1 year ago

hveravallaskreppur commented 1 year ago

dvars now added in detectors.py and the findoutlie script uses dvars instead of z_score_detector. please review and merge @kaushik-pallavi (please accept the other PR first)

codecov[bot] commented 1 year ago

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Files Coverage Δ
findoutlie/__init__.py 100.00% <100.00%> (ø)
findoutlie/detectors.py 97.43% <96.66%> (-2.57%) :arrow_down:
findoutlie/tests/test_detectors.py 94.11% <96.15%> (+6.61%) :arrow_up:
findoutlie/outfind.py 30.00% <25.00%> (-3.34%) :arrow_down:

:loudspeaker: Thoughts on this report? Let us know!.

hveravallaskreppur commented 1 year ago

the tests all pass @kaushik-pallavi, I think it was just a codeCov service outage

hveravallaskreppur commented 1 year ago

about to send in another PR with GLM as metric, needed to accept PR first, @kaushik-pallavi