nipreps / dmriprep

dMRIPrep is a robust and easy-to-use pipeline for preprocessing of diverse dMRI data. The transparent workflow dispenses of manual intervention, thereby ensuring the reproducibility of the results.
https://www.nipreps.org/dmriprep
Apache License 2.0
63 stars 24 forks source link

FIX: Minor refactor of DWI/brainmasks utilities and dtypes #101

Closed oesteban closed 4 years ago

oesteban commented 4 years ago

This PR:

Future lines

We should think about dropping FSL MCFLIRT, which is used for HMC of the b = 0 volumes.

Resolves: #90

pull-assistant[bot] commented 4 years ago
Score: 1.00

Best reviewed: commit by commit


Optimal code review plan

     FIX: Minor refactor of DWI/brainmasks utilities and dtypes

Powered by Pull Assistant. Last update a66d685 ... a66d685. Read the comment docs.

codecov[bot] commented 4 years ago

Codecov Report

Merging #101 into master will increase coverage by 0.24%. The diff coverage is 15.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #101      +/-   ##
==========================================
+ Coverage   50.81%   51.06%   +0.24%     
==========================================
  Files          21       21              
  Lines        1222     1218       -4     
  Branches      162      161       -1     
==========================================
+ Hits          621      622       +1     
+ Misses        586      581       -5     
  Partials       15       15              
Impacted Files Coverage Δ
dmriprep/utils/images.py 15.00% <11.11%> (+1.66%) :arrow_up:
dmriprep/interfaces/images.py 71.42% <50.00%> (+0.84%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a27fc16...a66d685. Read the comment docs.

oesteban commented 4 years ago

Seems to resolve the issue -> https://314-233429127-gh.circle-artifacts.com/0/tmp/THP002/derivatives/dmriprep/sub-THP0005.html#acquisition-GD72_datatype-dwi_desc-brain_run-1_session-THP0005JHU1_suffix-mask