search

nipreps / dmriprep

dMRIPrep is a robust and easy-to-use pipeline for preprocessing of diverse dMRI data. The transparent workflow dispenses of manual intervention, thereby ensuring the reproducibility of the results.
https://www.nipreps.org/dmriprep
Apache License 2.0
63 stars 24 forks source link

MAINT: Refactor the workflow to use Nipype iterables #105

Closed oesteban closed 4 years ago

oesteban commented 4 years ago

This move will make it easier to integrate SDC, and in particular, the SDC scheduling @mattcieslak was preparing.

pull-assistant[bot] commented 4 years ago
Score: 1.00

Best reviewed: commit by commit

Optimal code review plan

     MAINT: Refactor the workflow to use Nipype iterables      docs: fix code in workflow directive / run black      enh: load config first (and trigger a new circleci build)

Powered by Pull Assistant. Last update 630b715 ... c03474e. Read the comment docs.

codecov[bot] commented 4 years ago

Codecov Report

Merging #105 into master will decrease coverage by 0.18%. The diff coverage is 44.64%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #105      +/-   ##
==========================================
- Coverage   51.92%   51.74%   -0.19%     
==========================================
  Files          21       20       -1     
  Lines        1219     1206      -13     
  Branches      161      160       -1     
==========================================
- Hits          633      624       -9     
+ Misses        574      570       -4     
  Partials       12       12
Impacted Files Coverage Δ
dmriprep/cli/run.py 4.10% <0.00%> (ø)
dmriprep/cli/workflow.py 2.94% <0.00%> (ø)
dmriprep/config/testing.py 26.92% <0.00%> (ø)
dmriprep/utils/bids.py 15.38% <0.00%> (ø)
dmriprep/utils/images.py 15.00% <0.00%> (ø)
dmriprep/utils/misc.py 50.00% <ø> (ø)
dmriprep/workflows/base.py 24.35% <10.71%> (-0.32%) :arrow_down:
dmriprep/interfaces/__init__.py 46.42% <20.00%> (ø)
dmriprep/workflows/dwi/base.py 42.10% <40.00%> (-4.57%) :arrow_down:
dmriprep/interfaces/reports.py 60.71% <47.82%> (ø)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9d95e73...c03474e. Read the comment docs.

oesteban commented 4 years ago

Okay, let's go for it