search

nipreps / dmriprep

dMRIPrep is a robust and easy-to-use pipeline for preprocessing of diverse dMRI data. The transparent workflow dispenses of manual intervention, thereby ensuring the reproducibility of the results.
https://www.nipreps.org/dmriprep
Apache License 2.0
63 stars 24 forks source link

ENH: Use new ``DerivativesDataSink`` from NiWorkflows 1.2.0 #108

Closed oesteban closed 4 years ago

oesteban commented 4 years ago

This PR integrates the new API that will be released with 1.2.0.

References: nipreps/niworkflows#507

pull-assistant[bot] commented 4 years ago
Score: 1.00

Best reviewed: commit by commit

Optimal code review plan

     enh: use new ``DerivativesDataSink`` from NiWorkflows 1.2.0

Powered by Pull Assistant. Last update de14073 ... de14073. Read the comment docs.

codecov[bot] commented 4 years ago

Codecov Report

Merging #108 into master will increase coverage by 0.04%. The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #108      +/-   ##
==========================================
+ Coverage   51.88%   51.92%   +0.04%     
==========================================
  Files          20       20              
  Lines        1222     1221       -1     
  Branches      161      161              
==========================================
  Hits          634      634              
+ Misses        576      575       -1     
  Partials       12       12
Impacted Files Coverage Δ
dmriprep/cli/run.py 4.10% <ø> (ø)
dmriprep/cli/workflow.py 2.94% <ø> (ø)
dmriprep/workflows/base.py 22.89% <0.00%> (ø)
dmriprep/workflows/dwi/base.py 44.44% <0.00%> (+2.33%) :arrow_up:
dmriprep/workflows/dwi/outputs.py 38.46% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f2df371...de14073. Read the comment docs.

oesteban commented 4 years ago

@josephmje any concerns?