search

nipreps / dmriprep

dMRIPrep is a robust and easy-to-use pipeline for preprocessing of diverse dMRI data. The transparent workflow dispenses of manual intervention, thereby ensuring the reproducibility of the results.
https://www.nipreps.org/dmriprep
Apache License 2.0
64 stars 24 forks source link

ENH: Minor refactor reorganizing base workflows, in prep for #97 #110

Closed oesteban closed 4 years ago

oesteban commented 4 years ago

Just to make the diff of #97 a bit cleaner.

pull-assistant[bot] commented 4 years ago
Score: 1.00

Best reviewed: commit by commit

Optimal code review plan

     enh: minor refactor reorganizing base workflows, in prep for #97

Powered by Pull Assistant. Last update 83f6ed1 ... 83f6ed1. Read the comment docs.

codecov[bot] commented 4 years ago

Codecov Report

Merging #110 into master will decrease coverage by 0.55%. The diff coverage is 14.28%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #110      +/-   ##
==========================================
- Coverage   51.92%   51.37%   -0.56%     
==========================================
  Files          20       20              
  Lines        1221     1238      +17     
  Branches      161      162       +1     
==========================================
+ Hits          634      636       +2     
- Misses        575      590      +15     
  Partials       12       12
Impacted Files Coverage Δ
dmriprep/workflows/dwi/base.py 47.05% <ø> (+2.61%) :arrow_up:
dmriprep/workflows/dwi/util.py 21.15% <11.76%> (-3.85%) :arrow_down:
dmriprep/workflows/base.py 22.35% <25.00%> (-0.54%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 25a20ba...83f6ed1. Read the comment docs.