Open josephmje opened 3 years ago
Could you rebase when #151 is merged?
I'll update this to see if I can figure out a parser that determines whether the data is shelled or sampled along the Cartesian grid. I've checked out the methods section of a few DSI papers and they seem to either report the maximum b value or a range (eg. x DWIs with diffusion weightings in the range of b = 100-4000 s/mm2 and x interleaved b = 0 scans). Perhaps a similar approach can be taken in our reportlet.
I'll update this to see if I can figure out a parser that determines whether the data is shelled or sampled along the Cartesian grid. I've checked out the methods section of a few DSI papers and they seem to either report the maximum b value or a range (eg. x DWIs with diffusion weightings in the range of b = 100-4000 s/mm2 and x interleaved b = 0 scans). Perhaps a similar approach can be taken in our reportlet.
Yes, this sounds fantastic.
Hello @josephmje, Thank you for updating!
Cheers! There are no style issues detected in this Pull Request. :beers: To test for issues locally, pip install flake8
and then run flake8 dmriprep
.
This is ready for review. I will leave the DSI updates for another PR.
@oesteban tests are failing after some of the changes to the dwi reference workflow. will wait until #153 gets merged and then will rebase
sounds great
should we resuscitate this?
Closes #64 and #128. Replaces PR #73.
DiffusionSummary
interfaceIn the case of DSI data, should
round_bvals
automatically round to the nearest 10 instead of calculating based on the magnitude of bvals? Setbmag = 1
.