pep8speaks
commented
2 years ago Hello @GalBenZvi, thank you for submitting the Pull Request!
- In the file
dmriprep/workflows/base.py:
Line 335:4: E261 at least two spaces before inline comment Line 335:5: E262 inline comment should start with '# ' Line 408:1: W293 blank line contains whitespace
- In the file
dmriprep/workflows/base_bak.py:
Line 332:4: E261 at least two spaces before inline comment Line 332:5: E262 inline comment should start with '# ' Line 366:1: W293 blank line contains whitespace
- In the file
dmriprep/workflows/base_mrtrix.py:
Line 335:4: E261 at least two spaces before inline comment Line 335:5: E262 inline comment should start with '# ' Line 340:1: W293 blank line contains whitespace Line 344:1: W293 blank line contains whitespace Line 369:12: F821 undefined name 'fmap_estimators' Line 377:15: F821 undefined name 'init_fmap_preproc_wf' Line 379:20: F821 undefined name 'fmap_estimators' Line 387:19: F821 undefined name 'fmap_estimators' Line 410:22: F821 undefined name 'fmap_estimators' Line 414:33: F821 undefined name 'fm' Line 414:58: F821 undefined name 'fm' Line 419:32: F821 undefined name 'fm' Line 428:32: F821 undefined name 'fm' Line 433:32: F821 undefined name 'fm'
- In the file
dmriprep/workflows/dwi_mrtrix/base.py:
Line 120:5: F401 'niworkflows.workflows.epi.refmap.init_epi_reference_wf' imported but unused Line 123:5: F401 '...interfaces.vectors.CheckGradientTable' imported but unused Line 124:5: F401 '.eddy.init_eddy_wf' imported but unused Line 125:5: F401 '.outputs.init_dwi_derivatives_wf' imported but unused Line 125:5: F401 '.outputs.init_reportlets_wf' imported but unused Line 140:9: F841 local variable 'has_fieldmap' is assigned to but never used Line 192:5: F841 local variable 'outputnode' is assigned to but never used Line 248:9: F841 local variable 'ds_report_reg' is assigned to but never used
- In the file
dmriprep/workflows/dwi_mrtrix/base_bak.py:
Line 391:19: W292 no newline at end of file
Line 1:1: F401 'dmriprep.workflows.dwi_mrtrix.pipelines.apply_transform.apply_transform.init_apply_transform' imported but unused
Line 1:1: F401 'dmriprep.workflows.dwi_mrtrix.pipelines.conversions.mif_conversions.conversions.init_mif_conversion_wf' imported but unused
Line 14:1: F401 'traits.trait_base._Undefined' imported but unused Line 43:100: E501 line too long (110 > 99 characters)
Line 1:1: F401 'dmriprep.workflows.dwi_mrtrix.pipelines.derivatives.derivatives.init_derivatives_wf' imported but unused
Line 2:1: F401 'dmriprep.workflows.dwi_mrtrix.pipelines.derivatives.edges.COREG_SBREF_LIST_TO_DDS_EDGES' imported but unused Line 68:100: E501 line too long (121 > 99 characters)
Line 1:1: F401 'sklearn.pipeline' imported but unused Line 3:1: F811 redefinition of unused 'init_epi_ref_wf' from line 2 Line 3:1: F401 'dmriprep.workflows.dwi_mrtrix.pipelines.epi_ref.epi_ref.init_epi_ref_wf' imported but unused
Line 1:1: F401 'dmriprep.workflows.dwi_mrtrix.pipelines.epi_reg.epi_reg.init_epireg_wf' imported but unused
Line 13:1: F401 'nipype.interfaces.fsl' imported but unused Line 14:1: F401 'nipype.interfaces.utility as niu' imported but unused
Line 1:1: F401 'dmriprep.workflows.dwi_mrtrix.pipelines.pre_sdc.pre_sdc.add_fieldmaps_to_wf' imported but unused Line 1:1: F401 'dmriprep.workflows.dwi_mrtrix.pipelines.pre_sdc.pre_sdc.init_phasediff_wf' imported but unused
Line 130:100: E501 line too long (124 > 99 characters)
Line 1:1: F401 'dmriprep.workflows.dwi_mrtrix.pipelines.preprocess.preprocess.init_preprocess_wf' imported but unused
To test for issues locally, pip install flake8 and then run flake8 dmriprep.
Adde brain masks for DWI in both T1w and DWI spaces.