nipreps / dmriprep

dMRIPrep is a robust and easy-to-use pipeline for preprocessing of diverse dMRI data. The transparent workflow dispenses of manual intervention, thereby ensuring the reproducibility of the results.
https://www.nipreps.org/dmriprep
Apache License 2.0
63 stars 24 forks source link

Determine number of shells #64

Closed oesteban closed 1 year ago

oesteban commented 4 years ago

I know @edickie and @mattcieslak were working on this.

I would suggest adding this as a cached method (i.e., only called once and then cached) of the DiffusionGradientTable object https://github.com/nipreps/dmriprep/blob/0a609b4c91c97b6b2bb0fad0f35ce2e7d15f44b3/dmriprep/utils/vectors.py#L12-L178

oesteban commented 3 years ago

Just to note it down: what happens with cartesian samplings of the q-space? (e.g., DSI) - will this give a proper output @edickie?

/cc @josephmje for what this affects the tutorial

oesteban commented 1 year ago

Done in MRIQC - we should upstream somewhere to share with dMRIPrep. Closing this for the time being.