search

nipreps / eddymotion

Open-source eddy-current and head-motion correction for dMRI.
https://nipreps.org/eddymotion
Apache License 2.0
13 stars 16 forks source link

FIX: Generalized model structure #221

Closed oesteban closed 1 month ago

oesteban commented 1 month ago

Reorganizes models so that dMRI is not so ubiquitous.

oesteban commented 1 month ago

I'm sure @mnoergaard will be happy to see the PET model in its own submodule, finally separated from DWI aspects such as b0, gradients, etc.

I know @jhlegarreta will be less happy with me rushing the merge of this refactor, but I will need some agility these days to advance eddymotion into a more performant state. Happy to address issues and oversights post-hoc :)

I'm going to merge this in 20 minutes, so that, if someone is actively reviewing, please let me know and I will wait for those reviews.

jhlegarreta commented 1 month ago

Cannot review now; go ahead and merge.

mnoergaard commented 1 month ago

Hi @oesteban and @jhlegarreta. Thanks for pushing these efforts forward - I didn't get to reviewing this in time either. Will be able to dedicate more time to eddymotion next week.