nipreps / eddymotion

Open-source eddy-current and head-motion correction for dMRI.
https://nipreps.org/eddymotion
Apache License 2.0
13 stars 16 forks source link

Integration and validation tests with b=0 only #40

Closed oesteban closed 2 years ago

oesteban commented 3 years ago

Two low-hanging fruit tests using only a b=0:

oesteban commented 2 years ago

Okay, I've tried to set up some basics, and implemented a unit-test for the TrivialB0Model sketching what we intend to do here:

https://github.com/nipreps/eddymotion/blob/152e0d4aeb6917965ed1821ea1507fb68630fa3b/eddymotion/tests/test_model.py#L29-L42

Unit tests of ANTs' config for b=0.

I see this implemented in test_estimator.py. To do so:

Introduce a series of transforms (e.g., copy them from another dataset) and resample the b=0 through that motion series. Then run the whole estimator and check the proximity of the estimated transforms.

I see this implemented in test_integration.py. To do so:

oesteban commented 2 years ago

Hi there! I've uploaded some data under https://github.com/nipreps/eddymotion/tree/main/eddymotion/tests/data, generated by @dPys with FiberFox.

sebastientourbier commented 2 years ago

@oesteban I am progressing! For now, I managed to:

I haven't opened a PR yet but here is a quick preview of the motion introduced

b0 moving

What do think?

dPys commented 2 years ago

This looks so awesome.