search

nipreps / mriqc

Automated Quality Control and visual reports for Quality Assessment of structural (T1w, T2w) and functional MRI of the brain
http://mriqc.readthedocs.io
Apache License 2.0
299 stars 132 forks source link

remove slice-timing correction #1019

Closed psadil closed 2 years ago

psadil commented 2 years ago

Closes #998 by removing ability to correct for slice-timing (which had only worked for some acquisitions)

psadil commented 2 years ago

I'm not confident, but I think those failures are caused by changes outside this request. Perhaps I should have started from the last release rather than the master branch?

oesteban commented 2 years ago

Thanks much for this. Can you please rebase to upstream/master? The errors should be fixed now.

Let's see if the tests indeed pass. When merged, please do not forget to add your info to https://github.com/nipreps/mriqc/blob/master/.maint/CONTRIBUTORS.md, in case you wish so.

welcome[bot] commented 2 years ago

Thanks for opening this pull request and congratulations for taking it to the finish line! It looks like this is your first time contributing to MRIQC. :smile: We invite you to list yourself as an MRIQC contributor. To learn more about what that entails and how we credit our contributors, please check out the contributing guidelines. If your name is not already on the list, please insert it, in alphabetical order of (i) lastname and (ii) firstname, into the .maint/CONTRIBUTORS.md file. Of course, if you want to opt-out this time, there is no problem at all with adding your name later. You will be always welcome to add it in the future whenever you feel it should be listed.