search

nipreps / mriqc

Automated Quality Control and visual reports for Quality Assessment of structural (T1w, T2w) and functional MRI of the brain
http://mriqc.readthedocs.io
Apache License 2.0
299 stars 132 forks source link

FIX: Underspecified regex sets BIDSLayout to ignore data with sesions #1094

Closed oesteban closed 1 year ago

oesteban commented 1 year ago

This PR removes one ignore pattern that resulted in ignoring all data when sessions are defined.

To preempt regressions, a simple test is added, using data structures from @dmd (see #921 (comment)).

I will be adding more test structures from https://github.com/nipreps/mriqc/issues/921 and other reported problems.

Resolves https://github.com/nipreps/mriqc/issues/1086.

oesteban commented 1 year ago

The new tests are passing on circle:

mriqc/tests/test_config.py::test_bids_indexing_manifest[gh921-dmd-20220428-0] PASSED
mriqc/tests/test_config.py::test_bids_indexing_manifest[gh921-dmd-20230319-0] PASSED
mriqc/tests/test_config.py::test_bids_indexing_manifest[gh1086-ds004134] PASSED