nipreps / mriqc

Automated Quality Control and visual reports for Quality Assessment of structural (T1w, T2w) and functional MRI of the brain
http://mriqc.readthedocs.io
Apache License 2.0
300 stars 132 forks source link

FIX: adapt code so it works with different versions of networkx #1137

Closed celprov closed 1 year ago

celprov commented 1 year ago

fix: Resolve dependency issue with newer version of networkx

Closes #1136

celprov commented 1 year ago

@esavary @oesteban GitHub action build (3.11, pip==21.2) complains there is no space left on the device. Is there something that should be done at the organization level to solve this issue?

Error: uld consider upgrading via the '/tmp/install_wheel/bin/python -m pip install --upgrade p2023-09-11T20:22:28.8880057Z ##[error]No space left on device : '/home/runner/runners/2.308.0/_diag/pages/97591c64-e054-4d6f-89f6-8ddafade3bbf_e054ce87-d82e-512d-3ab3-06d2fef876a4_1.log'

PS as it also fails on PR #1140 it seems more likely the problem is GitHub action itself than my code.

effigies commented 1 year ago

Since this looks like mostly a copy from nipype, it might be best just to copy what we did in nipype: https://github.com/nipy/nipype/commit/443492e82f3b197ad739cb244912ced652853a8d

pep8speaks commented 1 year ago

Hello @celprov, Thank you for updating!

Line 183:80: E501 line too long (89 > 79 characters) Line 290:80: E501 line too long (89 > 79 characters) Line 291:80: E501 line too long (95 > 79 characters) Line 308:80: E501 line too long (95 > 79 characters) Line 345:80: E501 line too long (80 > 79 characters) Line 348:80: E501 line too long (85 > 79 characters) Line 503:80: E501 line too long (93 > 79 characters)

To test for issues locally, pip install flake8 and then run flake8 niworkflows.

Comment last updated at 2023-09-19 17:56:05 UTC
celprov commented 1 year ago

Since this looks like mostly a copy from nipype, it might be best just to copy what we did in nipype: nipy/nipype@443492e

Thanks @effigies for the suggestion. I implemented it in the last commit.