search

nipreps / mriqc

Automated Quality Control and visual reports for Quality Assessment of structural (T1w, T2w) and functional MRI of the brain
http://mriqc.readthedocs.io
Apache License 2.0
299 stars 132 forks source link

ENH: store confound timeseries data #1166

Closed psadil closed 11 months ago

psadil commented 11 months ago

Closes #992

The timeseries data are stored in a tsv file matching [input_bids]_timeseries.tsv, with an accompanying json sidecar [input_bids]_timeseries.json

Columns contain 6 motion parameters, DVARS, AFNI’s outlier ratio, and AFNI’s quality index

(Sorry that this took so long to push through!)

psadil commented 11 months ago

I see that flake8 tests are failing due to more than just the changes in this pull (and that I've contributed to the mess). Should I aim to get the flake8 tests to pass?

Also, not sure what to make of the failing T1w test. The values are close. Has something recently been modified that would change numerical precision?

effigies commented 11 months ago

I would rebase on the latest master, which is linting clean. Then you should only have issues in your code to address.

psadil commented 11 months ago

Thanks for the speedy review!

I don't think that the ci/circleci T1w failure is related to this pull request, but let me know if I should look into it as a part of this.

effigies commented 11 months ago

No, that's unrelated.