nipreps / mriqc

Automated Quality Control and visual reports for Quality Assessment of structural (T1w, T2w) and functional MRI of the brain
http://mriqc.readthedocs.io
Apache License 2.0
299 stars 132 forks source link

bug from #1128 fixed? #1177

Closed abfeld007 closed 8 months ago

abfeld007 commented 10 months ago

Hi I am running MRIQC v23.1.0, but I still got the 'dwi' error when I am not using any DWI files (and my dataset passed the bids validator).

Traceback (most recent call last):
File "/opt/homebrew/bin/mriqc", line 8, in
sys.exit(main())
^^^^^^
File "/opt/homebrew/lib/python3.11/site-packages/mriqc/cli/run.py", line 206, in main
dataframe, out_tsv = generate_tsv(output_dir, mod)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/opt/homebrew/lib/python3.11/site-packages/mriqc/utils/misc.py", line 181, in generate_tsv
jsonfiles = list(output_dir.glob("sub-/**/%s/sub-_%s.json" % (IMTYPES[mod], mod)))
~~~~~~~^^^^^
KeyError: 'dwi'

What command did you use?

mriqc NIFTIS output/, 'group'

What version of the software are you running?

23.1.0

How are you running this software?

Local installation ("bare-metal")

Is your data BIDS valid?

Yes

Are you reusing any previously computed results?

No

Please copy and paste any relevant log output.

No response

Additional information / screenshots

No response

abfeld007 commented 9 months ago

Hi, any thoughts?

effigies commented 9 months ago

This was fixed in #1148, but there hasn't been a release.

@oesteban @celprov Is there a 24.0 release in the near future, or would it make sense to backport some bug-fixes on top of a maint/23.1.x branch and release a 23.1.1?

effigies commented 9 months ago

@abfeld007 I assume you pip installed this. You could upgrade to the latest master with:

pip install git+https://github.com/nipreps/mriqc.git
oesteban commented 9 months ago

@oesteban @celprov Is there a 24.0 release in the near future, or would it make sense to backport some bug-fixes on top of a maint/23.1.x branch and release a 23.1.1?

we should :) so yes

abfeld007 commented 9 months ago

yes. I did pip install. I'll try upgrading with the latest master.

celprov commented 9 months ago

@effigies @oesteban if you back port some bug fixes and release 23.1.1, you should also merge #1179.

NeuroimagingOL commented 8 months ago

Dear all, I also have the same problem when trying to run the group level. I just installed the lastest version, but this problem is still the same. Is there any work around so far or how can I access the group level data?

oesteban commented 8 months ago

This was fixed in #1148, but there hasn't been a release.

@oesteban @celprov Is there a 24.0 release in the near future, or would it make sense to backport some bug-fixes on top of a maint/23.1.x branch and release a 23.1.1?

Last time, I responded too fast without grasping the meaning of the comment. Now, I have just released 23.1.1, started maint/23.1.x and will start the roadmap toward releasing a 24.0.0 release.

@abfeld007 @NeuroimagingOL please open a new issue if the problem persists with 23.1.1