search

nipreps / mriqc

Automated Quality Control and visual reports for Quality Assessment of structural (T1w, T2w) and functional MRI of the brain
http://mriqc.readthedocs.io
Apache License 2.0
284 stars 128 forks source link

FIX: Move from ``pkg_resources`` to ``niworkflows.data.Loader`` #1199

Closed oesteban closed 3 months ago

oesteban commented 3 months ago

pkg_resources is deprecated as an API.

oesteban commented 3 months ago

Ouch. Thanks

On Tue, Mar 19, 2024, 16:11 Chris Markiewicz @.***> wrote:

@.**** commented on this pull request.

In mriqc/reports/individual.py https://github.com/nipreps/mriqc/pull/1199#discussion_r1530585084:

from nireports.assembler.report import Report +from niworkflows.data import Loader + +_load_data = Loader(package)

I don't think this is going to work quite how you want. I'm pretty sure this will load relative to mriqc.reports.individual. I would suggest instead having data/init.py define load_data and import from there.

— Reply to this email directly, view it on GitHub https://github.com/nipreps/mriqc/pull/1199#pullrequestreview-1946566536, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAESDRS2UI5LUNVJMN7LKRLYZBISVAVCNFSM6AAAAABE5W7ODSVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTSNBWGU3DMNJTGY . You are receiving this because you modified the open/close state.Message ID: @.***>