search

nipreps / mriqc

Automated Quality Control and visual reports for Quality Assessment of structural (T1w, T2w) and functional MRI of the brain
http://mriqc.readthedocs.io
Apache License 2.0
284 stars 128 forks source link

STY: Add *Ruff* config and fix all warnings and errors #1203

Closed oesteban closed 3 months ago

DimitriPapadopoulos commented 3 months ago

@oesteban Do you intend to add a CI job for ruff, in addition to or instead of the flake8 CI job?

oesteban commented 3 months ago

Yup, happy to review a PR :)

DimitriPapadopoulos commented 3 months ago

I guess instead of flake8?

DimitriPapadopoulos commented 3 months ago

Also, while I am not a big fan of .pre-commit, it is recommended by Repo-Review: https://learn.scientific-python.org/development/guides/repo-review/?repo=nipreps%2Fmriqc&branch=master

How about adding support for .pre-commit instead of explicitly running a ruff job?

oesteban commented 3 months ago

I would prefer to stay away from pre-commit. It places some burden on the contributor to set it up and I don't love how the project is driven.

The only gain is averting some CI tests to fail. I think we can live with that.