search

nipreps / mriqc

Automated Quality Control and visual reports for Quality Assessment of structural (T1w, T2w) and functional MRI of the brain
http://mriqc.readthedocs.io
Apache License 2.0
284 stars 128 forks source link

CI: flake8 → ruff check #1212

Closed DimitriPapadopoulos closed 3 months ago

DimitriPapadopoulos commented 3 months ago

I have replaced the flake8 CI job with a ruff CI job.

I don't have much experience with pep8speaks. From .pep8speaks.yml:

    linter: flake8

Should I and can I change flake8 to ruff? I don't think pep8speaks supports ruff:

Any clue?

oesteban commented 3 months ago

We should drop pep8speaks - we are slowly transitioning all projects to ruff (and only ruff).

Thanks for this!

DimitriPapadopoulos commented 3 months ago

Thanks for removing the pep8speaks config file. We also need to remove the flake8 configuration from pyproject.toml.

oesteban commented 3 months ago

Thanks for removing the pep8speaks config file. We also need to remove the flake8 configuration from pyproject.toml.

Do you want to go ahead and commit that?

DimitriPapadopoulos commented 3 months ago

I don't have convenient access to GitHub right now, please proceed if you can.