nipreps / mriqc

Automated Quality Control and visual reports for Quality Assessment of structural (T1w, T2w) and functional MRI of the brain
http://mriqc.readthedocs.io
Apache License 2.0
300 stars 132 forks source link

Do not clean up FA for degenerate tensors within DTI node #1215

Closed oesteban closed 8 months ago

oesteban commented 8 months ago

What happened?

We are immediately cleaning up the FA: https://github.com/nipreps/mriqc/blob/61b59e01777fccd381fee9ac4ffc28a7b65c2f5c/mriqc/interfaces/diffusion.py#L472-L473 and that precludes that we calculate the percentage of degenerate tensors as an IQM or plot them highlighted for visual QA/QC.

Methods that require a "massaged" FA (e.g., to calculate the CC mask) should take these two easy steps on their own.

/cc @arokem @teresamg

What command did you use?

-m dwi

What version of the software are you running?

master

How are you running this software?

Local installation ("bare-metal")

Is your data BIDS valid?

Yes

Are you reusing any previously computed results?

No

Please copy and paste any relevant log output.

No response

Additional information / screenshots

No response

arokem commented 8 months ago

What's the point of the FA file? Where is it used subsequent to saving?

oesteban commented 8 months ago

Generating the reports, mostly.

On Fri, Mar 22, 2024, 21:07 Ariel Rokem @.***> wrote:

What's the point of the FA file? Where is it used subsequent to saving?

— Reply to this email directly, view it on GitHub https://github.com/nipreps/mriqc/issues/1215#issuecomment-2015825967, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAESDRXOC3YNNDDHNXL3Q6LYZSFQHAVCNFSM6AAAAABFCWPDFOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMJVHAZDKOJWG4 . You are receiving this because you authored the thread.Message ID: @.***>