search

nipreps / mriqc

Automated Quality Control and visual reports for Quality Assessment of structural (T1w, T2w) and functional MRI of the brain
http://mriqc.readthedocs.io
Apache License 2.0
294 stars 130 forks source link

ENH: Add test for the CLI parser #1293

Closed jhlegarreta closed 4 months ago

jhlegarreta commented 5 months ago

Add test for the CLI parser.

jhlegarreta commented 5 months ago

Leaving the groups for a separate PR: https://github.com/nipreps/mriqc/blob/master/mriqc/cli/parser.py#L166

oesteban commented 5 months ago

Very much needed -- thanks for initiating this. Let me know how I can help.

jhlegarreta commented 5 months ago

Very much needed -- thanks for initiating this. Let me know how I can help.

Thanks Óscar. The CircleCI test errors seem unrelated: https://app.circleci.com/pipelines/github/nipreps/mriqc/1353/workflows/ae93f4b7-94c6-492c-9204-455abfcdd103/jobs/8173?invite=true#step-103-264_18 https://app.circleci.com/pipelines/github/nipreps/mriqc/1353/workflows/ae93f4b7-94c6-492c-9204-455abfcdd103/jobs/8174?invite=true#step-103-263_18

I think I had tried locally with success.

But is there a mechanism in place to fetch some testing data from Python? I see that a step in CircleCI retrieves some data from a URL

jhlegarreta commented 5 months ago

Thanks for the review and suggestions Óscar.

Created a helper _create_set_bids_dir as the pattern was being repeated.

Squashed commits.

Push forced. Not sure about the verbosity one. Will see in the CI.

welcome[bot] commented 4 months ago

Thanks for opening this pull request and congratulations for taking it to the finish line! It looks like this is your first time contributing to MRIQC. :smile: We invite you to list yourself as an MRIQC contributor. To learn more about what that entails and how we credit our contributors, please check out the contributing guidelines. If your name is not already on the list, please insert it, in alphabetical order of (i) lastname and (ii) firstname, into the .maint/CONTRIBUTORS.md file. Of course, if you want to opt-out this time, there is no problem at all with adding your name later. You will be always welcome to add it in the future whenever you feel it should be listed.