search

nipreps / sdcflows

Susceptibility Distortion Correction (SDC) workflows for EPI MR schemes
https://www.nipreps.org/sdcflows
Apache License 2.0
32 stars 26 forks source link

Revise ``InputMultiObject`` of the BSpline interface #386

Open oesteban opened 1 year ago

oesteban commented 1 year ago

See https://github.com/nipreps/sdcflows/pull/346/files#r1294641020

effigies commented 1 year ago

Noting that this is specifically about these inputs, since following this link is a little messy:

https://github.com/nipreps/sdcflows/blob/50ace2a4057d1712b3b12d814f61a819973c8856/sdcflows/interfaces/bspline.py#L302-L311

Seems confusing making these MultiObjects, since the first is always being used and the rest discarded - and we should specify that these need to be in ITK format.

This is for compatiblity with the nipype interface. We probably want not to drop linear transforms after the first, although it feels like a rabbit hole.

So, rather than operating here, I think we want to open an issue to think about how a list here should be managed later.