nipreps / sdcflows

Susceptibility Distortion Correction (SDC) workflows for EPI MR schemes
https://www.nipreps.org/sdcflows
Apache License 2.0
32 stars 26 forks source link

ENH: Add support for ASL data #411

Closed tsalo closed 11 months ago

tsalo commented 12 months ago

Closes none, but is related to #405. I'm happy to take a crack at adding tests, but it would be good to know what the preferred approach is. The easiest thing might be for me to just copy existing test files and rename them. I don't think distortion correction of EPI ASL will be any different from SDC of other EPI sequences, but I could add actual ASL and M0 data if that would be better. Unfortunately, I don't have access to data from a number of the cases listed below.

There are a few cases that I think should be covered. Do they make sense?

  1. ASL scan with AP and PA M0 scans located in fmap, with separate M0 scan in perf.
  2. AP ASL scan with PA M0 scan in fmap, with separate M0 scan in perf.
  3. AP and PA ASL scans (is that supported yet?), with separate M0 scan in perf.
  4. ASL scan with phase-difference field maps, with separate M0 scan in perf.
  5. ASL scan without any field map.

Changes proposed:

codecov[bot] commented 12 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (53482c1) 80.59% compared to head (3ef588a) 80.59%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #411 +/- ## ======================================= Coverage 80.59% 80.59% ======================================= Files 26 26 Lines 2293 2293 Branches 291 291 ======================================= Hits 1848 1848 Misses 401 401 Partials 44 44 ``` | [Flag](https://app.codecov.io/gh/nipreps/sdcflows/pull/411/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nipreps) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/nipreps/sdcflows/pull/411/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nipreps) | `∅ <ø> (∅)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nipreps#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.