Closed tsalo closed 6 months ago
Attention: Patch coverage is 19.83871%
with 497 lines
in your changes are missing coverage. Please review.
Project coverage is 66.28%. Comparing base (
73d717a
) to head (ed0f46c
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
I still need to figure out why the results don't look good, but I was thinking an alternative might be for me to simply integrate warpkit as a dependency and run that directly. Would that be preferable to a translated Nipype workflow?
If using warpkit significantly improves performance, all the more reason to wrap it rather than reimplement - it'll come with the added benefit of reducing longterm maintenance 😄
One hurdle that would add is a more complex installation - however if/when https://github.com/vanandrew/warpkit/issues/6 is resolved it would be a cinch
@mgxd I did what you proposed in #438, so I'll close this PR now.
Closes #36.
This currently runs on some test data, but I haven't evaluated the results.
Changes proposed:
sdcflows.workflows.fit.medic
module with MEDIC workflow.Still to do:
EnforceTemporalConsistency
more memory-efficient.