search

nipunsadvilkar / pySBD

🐍💯pySBD (Python Sentence Boundary Disambiguation) is a rule-based sentence boundary detection that works out-of-the-box.
MIT License
813 stars 84 forks source link

Escape abbreviation before substitution #81

Closed matthen closed 3 years ago

matthen commented 4 years ago

Fixes https://github.com/nipunsadvilkar/pySBD/issues/80

matthen commented 4 years ago

Perhaps there should be some unit tests for these functions?

nipunsadvilkar commented 4 years ago

Hey @matthen, Sorry for the late reply! was tied up in other commitments.

Yes, adding those unit tests would definitely help. Since PySBD is inspired by https://github.com/diasks2/pragmatic_segmenter, have kept tests and design pretty similar. Having said that, more tests are always welcome :)

Also, can you please take a pull from master? I've fixed the failing CI issue

matthen commented 4 years ago

Thanks Nipun! I have updated the branch and it looks like CI is passing. How about a separate PR to add a unit test that checks https://github.com/nipunsadvilkar/pySBD/issues/80 ?

nipunsadvilkar commented 4 years ago

Yes separate PR would be fine