search

nipwaayoni / elastic-apm-php-agent

PHP Agent for Elastic APM
Other
28 stars 15 forks source link

Span is not indexed when stacktrace is set #26

Closed dstepe closed 4 years ago

dstepe commented 4 years ago

Reported here:

https://github.com/philkra/elastic-apm-php-agent/issues/135

The schema validation should be able to catch this.

dstepe commented 4 years ago

It is true that vars is an object, but is property of stacktrace frame:

https://github.com/elastic/apm-server/blob/master/docs/spec/stacktrace_frame.json#L59

A stacktrace is defined as an array with the items of type stacktrace frame:

https://github.com/elastic/apm-server/blob/master/docs/spec/spans/span.json#L206

We will be creating a roadmap which includes a complete implementation of the object contract with APM. That will help to avoid issues like this while making it easier for users. For now however, there is nothing we can do with this issue.