search

nipwaayoni / elastic-apm-php-agent

PHP Agent for Elastic APM
Other
28 stars 15 forks source link

Event timer changes #32

Closed dstepe closed 4 years ago

dstepe commented 4 years ago

Closes #20 Closes #19

dstepe commented 4 years ago

@tsantos84 We have not talked about this, but my general rule is that who opens a conversation on a PR should be the person who decides to close it. That indicates an agreement that a resolution was reached. I would like to employ that philosophy here as well. Of course, if a participant becomes non-responsive, we can step in. Please review and close any conversations that you feel are complete.

I've also created projects for releases. I think we should start adding cards for things we want to do in in a release instead of opening an issue. I think we can easily open an issue from a card when we are ready to work on it. The projects will let us organize, prioritize and track progress toward the release.

I've added the current work in progress to the Release 7.1 project:

https://github.com/nipwaayoni/elastic-apm-php-agent/projects/1

I'm not sure how the permissioning works, so let me know if you can't see or update that project board.

I would like to work toward getting the 7.1 release out in the next few days. Let me know if you see any challenges in that. The work on the board is not difficult, but will make future changes easier.

tsantos84 commented 4 years ago

Hi @dstepe, We haven't talked about best practices and rules for reviewing but I agree with you. Sometime I've had doubts whether you or me should close the conversations. I've closed some of them but other I kept open. Sorry for that.

dstepe commented 4 years ago

@tsantos84 I think we are close to an initial 7.1 release for this package. I believe the open conversation on this PR has been addressed if you could review and close it. Once this one is merged to the 7.1-dev branch, I expect to have two more that address issues I considered important to complete before the release. I hope we can move those through quickly.

Once the 7.1 release is complete, we can start working on 7.2 which will have some of the more substantial internal changes we have been discussing. That work will be kept on a 7.2-dev branch so master can still be used for patches to 7.1, since I fully expect to find issues once it's in the wild.

I appreciate your assistance on the reviews. The result is much better for your efforts.