search

nipwaayoni / elastic-apm-php-agent

PHP Agent for Elastic APM
Other
28 stars 15 forks source link

Support timestamps in 32-bit environment #44

Closed pgross41 closed 4 years ago

pgross41 commented 4 years ago

https://github.com/nipwaayoni/elastic-apm-php-agent/issues/43

I'm unable to run the tests locally but the changes in the first commit https://github.com/nipwaayoni/elastic-apm-php-agent/commit/2473f9ab8889d3524bda4f9369eeb00a9c4562c4 fix the issue when used in our project. Perhaps we can close this and someone with more PHP experience can implement this correctly. Never mind... Unable to run this locally but the automated build is happy with my changes so I am too.

The unit test is still casting to int so that is a perfect test for this change. It shows that even though we now store the value as a float in memory, it ends up looking just like an int for APM.

dstepe commented 4 years ago

Can you change that target for the PR to the 7.2-dev branch? I'll collect a couple of other changes there and then merge that to master for release. Given the nature of the change, I think a minor release bump is warranted.

pgross41 commented 4 years ago

Sounds good, base branch updated.