search

nipwaayoni / elastic-apm-php-agent

PHP Agent for Elastic APM
Other
28 stars 15 forks source link

Add response to context #5

Closed tsantos84 closed 4 years ago

tsantos84 commented 4 years ago

Currently the EventBean is adding the response context inside of request context. As you can see on the official documentation request and response objects must be in the same level (e.g context's root). With this fix we can now see a dedicated tab to show response context on Kibana APM.

Original PR: https://github.com/philkra/elastic-apm-php-agent/pull/133

dstepe commented 4 years ago

I'm still re-familiarizing myself with the spec and code, so I'll probably asking questions for a while. I see what you mean about the placement of those objects, no problem. You mentioned that the response is currently "inside of request context". Should this change also remove the response from where it does not belong in addition to adding it to the correct location. The request schema does not include a response object either, so while maybe it doesn't create problems now, it is still not semantically correct, right?