search

nipwaayoni / elastic-apm-php-agent

PHP Agent for Elastic APM
Other
28 stars 15 forks source link

8.1 dev #85

Closed dstepe closed 1 year ago

dstepe commented 1 year ago

Adds tests running under PHP 8.2. Changes TimeStamp to int value (requires 64bit PHP).

dstepe commented 1 year ago

@cmtickle I pulled the type change you made up to the TimeStamp::asMicroSeconds() method. It seems to me that the value should be consistently represented by the class, not just when serializing to json. If you could test with the 8.1-dev branch, I would appreciate it. I'm not at a point where I can quickly test this right now. I'll get to in the next few days otherwise.

cmtickle commented 1 year ago

@dstepe I have tested my module with "nipwaayoni/elastic-apm-php-agent:dev-8.1-dev#2a4baba@dev" as a dependency. It works as expected. image

dstepe commented 1 year ago

@cmtickle Thanks for the assist. The 8.1-dev branch has been merged and 8.1.0 tagged and released.

cmtickle commented 1 year ago

@dstepe my Magento 2 integration module is already updated to depend on this. Thanks for turning it around so quickly.