search

nipy / PySurfer

Cortical neuroimaging visualization in Python
https://pysurfer.github.io/
BSD 3-Clause "New" or "Revised" License
240 stars 97 forks source link

Fix sample floatingpoint offby1 #126

Closed aestrivex closed 9 years ago

aestrivex commented 9 years ago

I noticed that save_movie() was creating movies slightly shorter than the desired length -- a 6 second movie would become a 5.8 seconds movie, for instance.

I think this is primarily an issue in ffmpeg which would be almost impossible to solve, but I also noticed a minor floating point instability in the calculation of the number of samples in my data.

agramfort commented 9 years ago

nice catch \ 2 !

agramfort commented 9 years ago

thanks heaps !

coveralls commented 9 years ago

Coverage Status

Coverage remained the same at 72.45% when pulling a8ee442622feada19c9e9d9dd944a7c9df0f4d9c on aestrivex:fix_sample_floatingpoint_offby1 into 330cbe1aec70219a1f903bb6936263e888aeb174 on nipy:master.