FIX Brain.save_movie(): prevent greater than possible frame times - Githubissues

nipy / PySurfer

Cortical neuroimaging visualization in Python

https://pysurfer.github.io/

BSD 3-Clause "New" or "Revised" License

240 stars 97 forks source link

FIX Brain.save_movie(): prevent greater than possible frame times #133

Closed christianbrodbeck closed 9 years ago

christianbrodbeck commented 9 years ago

np.arange() sometimes returns values larger than stop due to floating point round-off, which becomes relevant with large time_dilation values.

I hope that's the last fix for determining movie times :)

coveralls commented 9 years ago

Coverage increased (+0.05%) to 72.36% when pulling 82b02097acc8991e663ff5710764f3cbe72c11f0 on christianbrodbeck:movietimes into 4edbe61e55b13f3e8af9ff26597a1311b49bf8de on nipy:master.

coveralls commented 9 years ago

Coverage increased (+0.05%) to 72.36% when pulling 82b02097acc8991e663ff5710764f3cbe72c11f0 on christianbrodbeck:movietimes into 4edbe61e55b13f3e8af9ff26597a1311b49bf8de on nipy:master.

agramfort commented 9 years ago

let's see if Travis and @Eric89GXL are happy too

coveralls commented 9 years ago

Coverage increased (+0.05%) to 72.36% when pulling 00aec62b5cd4092ab688c3d2fec679bafe34b0ee on christianbrodbeck:movietimes into 4edbe61e55b13f3e8af9ff26597a1311b49bf8de on nipy:master.

coveralls commented 9 years ago

Coverage increased (+0.05%) to 72.36% when pulling 00aec62b5cd4092ab688c3d2fec679bafe34b0ee on christianbrodbeck:movietimes into 4edbe61e55b13f3e8af9ff26597a1311b49bf8de on nipy:master.

coveralls commented 9 years ago

Coverage increased (+0.05%) to 72.36% when pulling b99732fcde1a476c3a4f9deab106edbfdd9706b0 on christianbrodbeck:movietimes into 4edbe61e55b13f3e8af9ff26597a1311b49bf8de on nipy:master.

larsoner commented 9 years ago

Thanks for another fix @christianbrodbeck