search

nipy / PySurfer

Cortical neuroimaging visualization in Python
https://pysurfer.github.io/
BSD 3-Clause "New" or "Revised" License
240 stars 97 forks source link

add_data (and elsewhere we accept arrays) should convert input #140

Closed mwaskom closed 4 years ago

mwaskom commented 9 years ago

Been using pandas objects more lately and have been annoyed at having to use .values repeatedly, when pysurfer could easily call np.asarray on the inputs, I think.

larsoner commented 9 years ago

sounds reasonable to me

agramfort commented 9 years ago

fine with me too

larsoner commented 4 years ago

At least for add_data this appears to be implemented:

https://github.com/nipy/PySurfer/blob/master/surfer/viz.py#L1063

Feel free to open a quick PR if others are missing