nipy / PySurfer

Cortical neuroimaging visualization in Python
https://pysurfer.github.io/
BSD 3-Clause "New" or "Revised" License
240 stars 97 forks source link

ENH? silent errors on saving montage #146

Closed dengemann closed 7 years ago

dengemann commented 8 years ago

I'm a bit surprised about this line:

https://github.com/nipy/PySurfer/blob/master/surfer/viz.py#L152

It recently caused a lot trouble as images where not saved and subsequent report tools read in wrong temporary files from previous analyses. Why do we need a try/except block here? It is very difficult to learn something about the underlying issue if errors are silenced.

larsoner commented 8 years ago

I agree it's not a good idea to silence the warning, +1 for removing the try. I think if people want to have such uncertain behavior, they can do a try themselves. I can see why it might have been done orginally because an array is passed as the return, but users can still get the data with filename=None and then try saving it (with a try clause) if they want.

mwaskom commented 8 years ago

+1 for removing the try

+1

agramfort commented 8 years ago

+1