nipy / PySurfer

Cortical neuroimaging visualization in Python
https://pysurfer.github.io/
BSD 3-Clause "New" or "Revised" License
240 stars 97 forks source link

MRG: Py3k support #152

Closed larsoner closed 8 years ago

larsoner commented 8 years ago

Brings PySurfer py3k support. No CI support yet because Anaconda packages don't exist yet. But tests pass on my system with Mayavi dev and VTK 7.0.

Closes #143.

agramfort commented 8 years ago

Can you build the mne doc with it?

larsoner commented 8 years ago

I have some annoying backend conflicts with matplotlib when I try to do it, but I don't think it's PySurfer's problem

coveralls commented 8 years ago

Coverage Status

Changes Unknown when pulling a079c223ac9e2bed31b7d73d057b538bb1697413 on Eric89GXL:py3k into \ on nipy:master**.

agramfort commented 8 years ago

LGTM

larsoner commented 8 years ago

Thanks for the quick reviews. Now everyone gets to have fun building the VTK and Mayavi :)

mwaskom commented 8 years ago

Forgot to say cheers for doing the boring work here!

(But also, sotto voce boos for removing my main excuse for not switching to Python 3).

agramfort commented 8 years ago

no pain installing mayavi on your mac michael?

mwaskom commented 8 years ago

That's my current supplementary excuse. I haven't actually tried to use it yet :)