Closed christianbrodbeck closed 8 years ago
nice to see these red lines without reducing features :)
@agramfort I turned it into an optional dependency
@mwaskom @Eric89GXL any objection?
Otherwise LGTM
LGTM
I might make sense to update the save_movie parameters to give better access to the imageio options (http://imageio.readthedocs.io/en/latest/format_ffmpeg.html#parameters-for-saving) but that could be a second PR
Yeah a second PR would be good. Thanks @christianbrodbeck
Thanks!
Picking up an old suggestion from @Eric89GXL this uses imageio for saving movies. Imageio downlaods and manages the FFMPEG binary automatically so this would provide considerable simplification.