nipy / PySurfer

Cortical neuroimaging visualization in Python
https://pysurfer.github.io/
BSD 3-Clause "New" or "Revised" License
240 stars 97 forks source link

[WIP] Imageio #154

Closed christianbrodbeck closed 8 years ago

christianbrodbeck commented 8 years ago

Picking up an old suggestion from @Eric89GXL this uses imageio for saving movies. Imageio downlaods and manages the FFMPEG binary automatically so this would provide considerable simplification.

coveralls commented 8 years ago

Coverage Status

Coverage increased (+4.0%) to 76.261% when pulling 08d538aa65e8d3f8a9cdbe9e9658428946a39634 on christianbrodbeck:imageio into 40621da655859fd73404a2e6018953a4ad3daf10 on nipy:master.

agramfort commented 8 years ago

nice to see these red lines without reducing features :)

coveralls commented 8 years ago

Coverage Status

Coverage increased (+3.9%) to 76.19% when pulling 10135dad09dcb82427f1e077de84be535c356229 on christianbrodbeck:imageio into 40621da655859fd73404a2e6018953a4ad3daf10 on nipy:master.

christianbrodbeck commented 8 years ago

@agramfort I turned it into an optional dependency

agramfort commented 8 years ago

@mwaskom @Eric89GXL any objection?

larsoner commented 8 years ago

Otherwise LGTM

coveralls commented 8 years ago

Coverage Status

Coverage increased (+3.9%) to 76.19% when pulling c5ecdb723688bdcb2a7dacb3ccc4d40a0948c32b on christianbrodbeck:imageio into 40621da655859fd73404a2e6018953a4ad3daf10 on nipy:master.

coveralls commented 8 years ago

Coverage Status

Coverage increased (+3.9%) to 76.19% when pulling f2190219a961bda9b3525fea6486cb0b8dd51667 on christianbrodbeck:imageio into 40621da655859fd73404a2e6018953a4ad3daf10 on nipy:master.

coveralls commented 8 years ago

Coverage Status

Coverage increased (+3.9%) to 76.19% when pulling f2190219a961bda9b3525fea6486cb0b8dd51667 on christianbrodbeck:imageio into 40621da655859fd73404a2e6018953a4ad3daf10 on nipy:master.

mwaskom commented 8 years ago

LGTM

christianbrodbeck commented 8 years ago

I might make sense to update the save_movie parameters to give better access to the imageio options (http://imageio.readthedocs.io/en/latest/format_ffmpeg.html#parameters-for-saving) but that could be a second PR

larsoner commented 8 years ago

Yeah a second PR would be good. Thanks @christianbrodbeck

christianbrodbeck commented 8 years ago

Thanks!