[MRG] figure args - Githubissues

nipy / PySurfer

Cortical neuroimaging visualization in Python

https://pysurfer.github.io/

BSD 3-Clause "New" or "Revised" License

240 stars 97 forks source link

[MRG] figure args #157

Closed christianbrodbeck closed 7 years ago

christianbrodbeck commented 8 years ago

The option to specify figure as int and the type check were in men-python (see https://github.com/mne-tools/mne-python/pull/3375), should they be included in PySurfer?

coveralls commented 8 years ago

Coverage decreased (-0.04%) to 76.121% when pulling 31d61fa2637ba626e37cd33f0cec3c50b8dda3b9 on christianbrodbeck:figure into 79beb158a73419cebe43ce716db62308dd4e756e on nipy:master.

larsoner commented 8 years ago

Yeah that makes sense to me, but don't forget to document the option, too

coveralls commented 8 years ago

Coverage decreased (-0.04%) to 76.121% when pulling 486e6a0c206f2e73da328e9af795a024552377d1 on christianbrodbeck:figure into 79beb158a73419cebe43ce716db62308dd4e756e on nipy:master.

coveralls commented 8 years ago

Coverage decreased (-0.04%) to 76.121% when pulling f2aacbfebfdda085c7be581c7ceb67713c6ca60e on christianbrodbeck:figure into 79beb158a73419cebe43ce716db62308dd4e756e on nipy:master.

larsoner commented 7 years ago

@christianbrodbeck I just saw that this is MRG. Still ready from your end?

christianbrodbeck commented 7 years ago

I could add a test with figure=int?

larsoner commented 7 years ago

Might as well, yeah

coveralls commented 7 years ago

Coverage decreased (-0.04%) to 77.206% when pulling 5aad7128181b0a87690dc034ed6a3db4eb160b8d on christianbrodbeck:figure into be31a94e4d35ffb00d64a9d9a0976c45bbb037a3 on nipy:master.

larsoner commented 7 years ago

needs rebase

coveralls commented 7 years ago

Coverage increased (+0.0006%) to 77.633% when pulling 253b98b308990de1d3b02bd25a9c41a053052b61 on christianbrodbeck:figure into 90f0d42e5f12ed36c9f72507a5172f5e32336d13 on nipy:master.

coveralls commented 7 years ago

Coverage increased (+0.0006%) to 77.633% when pulling 253b98b308990de1d3b02bd25a9c41a053052b61 on christianbrodbeck:figure into 90f0d42e5f12ed36c9f72507a5172f5e32336d13 on nipy:master.

larsoner commented 7 years ago

CIs are happy, good to go?

christianbrodbeck commented 7 years ago

yes

agramfort commented 7 years ago

thx @christianbrodbeck