[MRG] ENH: Set initial time in Brain.add_data()

nipy / PySurfer

Cortical neuroimaging visualization in Python

https://pysurfer.github.io/

BSD 3-Clause "New" or "Revised" License

240 stars 97 forks source link

[MRG] ENH: Set initial time in Brain.add_data() #158

Closed christianbrodbeck closed 8 years ago

christianbrodbeck commented 8 years ago

Following up on https://github.com/mne-tools/mne-python/pull/3375 CC @jaeilepp @Eric89GXL

coveralls commented 8 years ago

Coverage decreased (-0.03%) to 76.157% when pulling 893e056e22c402b3ae72aa788c9d3191d8095d2f on christianbrodbeck:add_data into 75daf5556d4e988c0ace2fffcfa295e0dd8b509f on nipy:master.

agramfort commented 8 years ago

LGTM

+1 for merge if you're done.

christianbrodbeck commented 8 years ago

Updated the example. If others agree with the API then this is ready.

coveralls commented 8 years ago

Coverage decreased (-0.03%) to 76.157% when pulling 6445a2b6c9ef85cbad77270b1e39d77efa32cf36 on christianbrodbeck:add_data into 75daf5556d4e988c0ace2fffcfa295e0dd8b509f on nipy:master.

agramfort commented 8 years ago

LGTM

larsoner commented 8 years ago

Otherwise LGTM, but you should probably also add a test that the parameter at least can be passed in

coveralls commented 8 years ago

Coverage increased (+0.8%) to 77.02% when pulling c36d445e9c1c4311dfde2501f0a1eca8343faac3 on christianbrodbeck:add_data into 75daf5556d4e988c0ace2fffcfa295e0dd8b509f on nipy:master.

coveralls commented 8 years ago

Coverage increased (+0.8%) to 77.02% when pulling c36d445e9c1c4311dfde2501f0a1eca8343faac3 on christianbrodbeck:add_data into 75daf5556d4e988c0ace2fffcfa295e0dd8b509f on nipy:master.

coveralls commented 8 years ago

Coverage increased (+0.8%) to 77.02% when pulling c36d445e9c1c4311dfde2501f0a1eca8343faac3 on christianbrodbeck:add_data into 75daf5556d4e988c0ace2fffcfa295e0dd8b509f on nipy:master.

christianbrodbeck commented 8 years ago

Ready and tests pass, added test and doc.

larsoner commented 8 years ago

Otherwise LGTM

coveralls commented 8 years ago

Coverage increased (+0.8%) to 77.02% when pulling d12d48df8a2dbefb8e7e14590eabc7f4d75f0025 on christianbrodbeck:add_data into 75daf5556d4e988c0ace2fffcfa295e0dd8b509f on nipy:master.

christianbrodbeck commented 8 years ago

Good catch @Eric89GXL

larsoner commented 8 years ago

Thanks @christianbrodbeck