search

nipy / PySurfer

Cortical neuroimaging visualization in Python
https://pysurfer.github.io/
BSD 3-Clause "New" or "Revised" License
240 stars 97 forks source link

[MRG] FIX Brain.remove labels() #185

Closed christianbrodbeck closed 7 years ago

christianbrodbeck commented 7 years ago

Remove the hemi parameter, which was previously unused (even though it forced the user to set it). Labels are not stored by hemisphere, but by their name.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.4%) to 78.362% when pulling 6affeab8a1f80c58b36bc1fbe7c6b3c4825265e7 on christianbrodbeck:fix/remove_labels into 86481141fc375086b950c75d419290d75e56155c on nipy:master.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.4%) to 78.362% when pulling 6affeab8a1f80c58b36bc1fbe7c6b3c4825265e7 on christianbrodbeck:fix/remove_labels into 86481141fc375086b950c75d419290d75e56155c on nipy:master.

larsoner commented 7 years ago

LGTM. @mwaskom can you look?

mwaskom commented 7 years ago

Code looks good to me. Are we still ignoring AppVeyor failures?

larsoner commented 7 years ago

It seems unrelated