FIX toggle_render: store camera parallel_scale

nipy / PySurfer

Cortical neuroimaging visualization in Python

https://pysurfer.github.io/

BSD 3-Clause "New" or "Revised" License

240 stars 97 forks source link

FIX toggle_render: store camera parallel_scale #186

Closed christianbrodbeck closed 7 years ago

christianbrodbeck commented 7 years ago

mlab.view() does not return parallel_scale (which only becomes apparent when setting the camera to use parallel projection)

larsoner commented 7 years ago

LGTM but the CI failures are real (due to testing backend, probably)

coveralls commented 7 years ago

Coverage increased (+0.01%) to 78.372% when pulling 4f631d131de3e5c78d19abc8594fdc48f110190c on christianbrodbeck:parallel_scale into 69e969b3698314470ce37f608651dd7493316db9 on nipy:master.

coveralls commented 7 years ago

Coverage increased (+0.01%) to 78.372% when pulling 4f631d131de3e5c78d19abc8594fdc48f110190c on christianbrodbeck:parallel_scale into 69e969b3698314470ce37f608651dd7493316db9 on nipy:master.

larsoner commented 7 years ago

Travis is happy now, changes LGTM. Any other reviewer?

mwaskom commented 7 years ago

I've never used this option so I don't have a deep understanding, but the code looks straightforward to me.

christianbrodbeck commented 7 years ago

Can this be merged?

larsoner commented 7 years ago

Yeah, thanks for the reminder and fixes @christianbrodbeck

christianbrodbeck commented 7 years ago

Thanks!