[MRG]: Set surface - Githubissues

nipy / PySurfer

Cortical neuroimaging visualization in Python

https://pysurfer.github.io/

BSD 3-Clause "New" or "Revised" License

240 stars 97 forks source link

[MRG]: Set surface #191

Closed christianbrodbeck closed 7 years ago

christianbrodbeck commented 7 years ago

I often find myself plotting with one surface and then wanting to look at it with another. This implementation is based on keeping track of all the meshes that are added to the brain. I've implemented it for data, labels and annotations, not yet for all other layer types because I wanted to confirm first that there is no better way to implement it. I was wondering whether all the mesh objects could be combined into one somehow (re #177), but it looks like they all need to have a different scalars attribute, and I don't see a straightforward way to separate the scalars from the triangular mesh...

coveralls commented 7 years ago

Coverage increased (+0.6%) to 79.008% when pulling 3c38be4a4f59e344a16d384b1a306737583d510c on christianbrodbeck:set_surface into 9fa66d3f4313b4234a63adbd9ddaf51da3d76d50 on nipy:master.

christianbrodbeck commented 7 years ago

This skips the parts that are broken under the testing backend, not great but it should work for now – the mne-python tests pass... I hope https://github.com/enthought/mayavi/pull/514 turns out to be a valid fix

coveralls commented 7 years ago

Coverage increased (+0.6%) to 79.044% when pulling e7fce43e1608f4e1601be9a388c552ed8f811aa9 on christianbrodbeck:set_surface into 9fa66d3f4313b4234a63adbd9ddaf51da3d76d50 on nipy:master.

larsoner commented 7 years ago

@mwaskom do you have time to look?

mwaskom commented 7 years ago

Thanks @christianbrodbeck!