nipy / PySurfer

Cortical neuroimaging visualization in Python
https://pysurfer.github.io/
BSD 3-Clause "New" or "Revised" License
240 stars 97 forks source link

ENH: Add doc build #195

Closed larsoner closed 7 years ago

larsoner commented 7 years ago

This should fix AppVeyor and make it build the docs (in noplot mode).

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 79.044% when pulling def2546b1779d539d2414a408c72cd8eac22396f on Eric89GXL:appveyor into 419a93bfbff9d349f05d8bf6977a1f36ab42b82c on nipy:master.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 79.044% when pulling ee43316e6b88aa68a90578bb7534685b0c9a1d8b on Eric89GXL:appveyor into 419a93bfbff9d349f05d8bf6977a1f36ab42b82c on nipy:master.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 79.044% when pulling c99d3f36fecdf7d72853ee713bb59ede09e771cf on Eric89GXL:appveyor into 419a93bfbff9d349f05d8bf6977a1f36ab42b82c on nipy:master.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.02%) to 79.066% when pulling f2186eba422f741d6c7cacb7b2b3e4a0f14ed1bb on Eric89GXL:appveyor into 419a93bfbff9d349f05d8bf6977a1f36ab42b82c on nipy:master.

larsoner commented 7 years ago

I'll merge this once the CIs are happy since it fixes AppVeyor

christianbrodbeck commented 7 years ago

Is reverting the mlab backend necessary to get the tests to work? It will make the tests less complete...

larsoner commented 7 years ago

They cause AppVeyor to crash

christianbrodbeck commented 7 years ago

I see... could we make it system-dependent?

larsoner commented 7 years ago

... they also cause windows to open locally during testing, which is less than ideal. The best thing would be to make Mayavi more fully support the test backend.

But I agree it's slightly better to cover more fully, so I'll make a commit to triage for Windows.

christianbrodbeck commented 7 years ago

Yeah I agree windows opening during testing are less than ideal... at least as it is now you can change to the test backend temporarily with one change.

larsoner commented 7 years ago

Okay we're green so I'll squash and merge. But if people feel like looking feel free and we can iterate.