ENH: Add annotation from arrays

nipy / PySurfer

Cortical neuroimaging visualization in Python

https://pysurfer.github.io/

BSD 3-Clause "New" or "Revised" License

240 stars 97 forks source link

ENH: Add annotation from arrays #202

Closed christianbrodbeck closed 7 years ago

christianbrodbeck commented 7 years ago

I've been creating annotations programmatically and wanted to plot them without saving them to a file first. The change simply allows providing the output of the file read operation directly, most of the changed lines are just due to indentation.

mwaskom commented 7 years ago

Very nice. I have a few thoughts on this, having almost implemented it several times before. I'll try to play around with it and give comments soon.

agramfort commented 7 years ago

LGTM

+1 for MRG when CIs are happy

agramfort commented 7 years ago

thx @christianbrodbeck

mwaskom commented 7 years ago

OK or maybe not :)

christianbrodbeck commented 7 years ago

I don't mind opening a new PR if you have suggestions :)