Closed larsoner closed 6 years ago
CircleCI is going to take hours because it's queued behind nipype
builds, but in the meantime AppVeyor and Travis are happy, so ready for review/merge from my end
I'll merge in a couple days unless anyone wants to take a look
Just made a couple small comments. Any idea how these changes lose 4% coverage?
Any idea how these changes lose 4% coverage?
I assume it's just coveralls being buggy, there seem to be a lot of false alarms with Coveralls
I assume it's just coveralls being buggy, there seem to be a lot of false alarms with Coveralls
Yeah ... I've found that codecov
seems to work a lot better. Anyway, not a blocker here.
:exclamation: No coverage uploaded for pull request base (
master@2fe06fa
). Click here to learn what that means. The diff coverage is76.47%
.
@@ Coverage Diff @@
## master #216 +/- ##
=========================================
Coverage ? 74.15%
=========================================
Files ? 8
Lines ? 2438
Branches ? 473
=========================================
Hits ? 1808
Misses ? 456
Partials ? 174
@mwaskom updated to fix text and add codecov
(couldn't resist)
A small tweak to ensure we check that
fmin < fmid < fmax
.