nipy / PySurfer

Cortical neuroimaging visualization in Python

https://pysurfer.github.io/

BSD 3-Clause "New" or "Revised" License

240 stars 97 forks source link

MRG: Check limit monotonicity #216

Closed larsoner closed 6 years ago

larsoner commented 6 years ago

A small tweak to ensure we check that fmin < fmid < fmax.

larsoner commented 6 years ago

CircleCI is going to take hours because it's queued behind nipype builds, but in the meantime AppVeyor and Travis are happy, so ready for review/merge from my end

larsoner commented 6 years ago

I'll merge in a couple days unless anyone wants to take a look

mwaskom commented 6 years ago

Just made a couple small comments. Any idea how these changes lose 4% coverage?

larsoner commented 6 years ago

Any idea how these changes lose 4% coverage?

I assume it's just coveralls being buggy, there seem to be a lot of false alarms with Coveralls

mwaskom commented 6 years ago

I assume it's just coveralls being buggy, there seem to be a lot of false alarms with Coveralls

Yeah ... I've found that codecov seems to work a lot better. Anyway, not a blocker here.

codecov-io commented 6 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@2fe06fa). Click here to learn what that means. The diff coverage is 76.47%.

@@            Coverage Diff            @@
##             master     #216   +/-   ##
=========================================
  Coverage          ?   74.15%           
=========================================
  Files             ?        8           
  Lines             ?     2438           
  Branches          ?      473           
=========================================
  Hits              ?     1808           
  Misses            ?      456           
  Partials          ?      174

larsoner commented 6 years ago

@mwaskom updated to fix text and add codecov (couldn't resist)